Skip to content

Close finite remote database connections - #112

Merged
vrtmrz merged 1 commit into
vrtmrz:mainfrom
apple-ouyang:codex/close-security-seed-remote-db
Aug 14, 2026
Merged

Close finite remote database connections#112
vrtmrz merged 1 commit into
vrtmrz:mainfrom
apple-ouyang:codex/close-security-seed-remote-db

Conversation

@apple-ouyang

@apple-ouyang apple-ouyang commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • close caller-owned remote PouchDB handles after finite replication, Security Seed refreshes, maintenance operations, and status queries
  • close continuous replication handles before retry or resurrection
  • close handles created by RemoteService.connect() when info() fails without replacing the original result

Verification

  • Commonlib: 1,300 unit tests, 7 boundary tests, 20 release tests, package build, and 6 managed integration tests
  • Self-hosted LiveSync 1.0.13: 638 unit tests, npm run check, and npm run build

Close temporary remote PouchDB handles after finite operations and before continuous replication retries. Preserve the original operation result when close fails, and cover ownership and failure paths with regression tests.
@apple-ouyang
apple-ouyang force-pushed the codex/close-security-seed-remote-db branch from e176e38 to 73f47ac Compare August 13, 2026 15:12
@apple-ouyang apple-ouyang changed the title Close remote databases used for Security Seed refresh Close finite remote database connections Aug 13, 2026
@apple-ouyang

Copy link
Copy Markdown
Contributor Author

Rebased on current main and expanded the fix to all finite remote-database owners, including connection setup failures and continuous retry/resurrection hand-off. Full Commonlib and downstream LiveSync verification passed.

@vrtmrz

vrtmrz commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Thank you very much. This is an excellent improvement!
Just one small clarification: I believe 'all finite owners' here means 'all finite owners within Commonlib'. That scope is entirely appropriate for a Commonlib pull request, but I wanted to note it explicitly.

I am very pleased that we can merge your contribution!

@vrtmrz
vrtmrz merged commit 5dc7115 into vrtmrz:main Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants