(love 11.0) Use normalized colors; fix broken sketch and filmgrain#58
Open
idbrii wants to merge 2 commits intovrld:masterfrom
Open
(love 11.0) Use normalized colors; fix broken sketch and filmgrain#58idbrii wants to merge 2 commits intovrld:masterfrom
idbrii wants to merge 2 commits intovrld:masterfrom
Conversation
Update to love 11.0 colour format where all colours are normalized.
Lua tables start at 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to love 11.0 colour format where all colours are normalized in [0,1].
Also fix some invalid indexing.
While some effects will continue to work so long as users pass 255 color values (desaturate, scanlines, vignette), the others are broken in love 11.0 without this change (sketch, filmgrain).
This change would break behaviour for use with love 0.10. Not sure how you want to deal with that. Maybe make a pre-11.0 tag?
sketch
Completely broken -- nearly no pixels modified.
filmgrain
Very broken -- few grains visible.
Test
I flipped through the effects in the demo and they all seem to work now (or at least have some effect).