Skip to content

chore(core): drop the unused VOS_VERSION constant from compiled output #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hblee12294 merged 1 commit into from
Aug 10, 2026
Merged

chore(core): drop the unused VOS_VERSION constant from compiled output #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/drop-dead-vos-version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@vosjs/core': patch
---

Drop the unused `VOS_VERSION` constant from compiled output. Every compiled module opened by declaring `const VOS_VERSION = <n>;` inside `initVos`, and nothing ever read it — not the runtime, not the bridge, not any consumer. The config's `version` field keeps its real job as the `migrateConfig` discriminator; only the dead emit goes.
3 changes: 0 additions & 3 deletions packages/core/src/compiler/compileVosConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ export function compileVosConfig(
throw new Error(`Invalid VosConfigJson:\n${issues}`)
}

const version = result.data.version

// Detect which addons are actually needed by scanning function strings
const detectedAddons = detectRequiredAddons(config)
// Declarative gltf objects need the loader even though no function string
Expand Down Expand Up @@ -222,7 +220,6 @@ ${utilEntries}


export const initVos = async (container, deps) => {
const VOS_VERSION = ${version};
const { THREE, gsap, resolution } = deps;

// Input data exposed as ctx.data (runtime deps.data overrides baked config.data; never undefined).
Expand Down
Loading