fix(core): text3d extrusion uses depth, not the removed height alias - #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextGeometry on current three (r183, the CDN pin) ignores the legacy
heightoption — the extrusion silently falls back to the default depth of 50. With bbox normalization (norm = 1/maxDim) that shrinks the glyph face to a sliver: 3D text rendered as a thin stick, and rotating revealed a long rod (the 50-deep extrusion).One-word fix: pass
depth. Verified against three r182/r183:height: 0.25→ z extent 50.04;depth: 0.25→ 0.29.🤖 Generated with Claude Code