feat(check): redefine --no-lint for type-check-only workflow#1444
feat(check): redefine --no-lint for type-check-only workflow#1444jong-kyung wants to merge 4 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| vp check --no-fmt --no-lint # Type-check only (requires `typeCheck` enabled). | ||
| ``` | ||
|
|
||
| When `lint.options.typeCheck` is enabled, `--no-lint` keeps type diagnostics by forwarding Oxlint's `--type-check-only` flag — useful for triaging type errors without lint noise. If `typeCheck` is not enabled, `--no-lint` simply skips the lint phase altogether, and `vp check --no-fmt --no-lint` exits with `No checks enabled` (enable `lint.options.typeCheck` to use the type-check-only invocation). |
There was a problem hiding this comment.
"by forwarding Oxlint's --type-check-only flag — useful for triaging type errors without lint noise."
This, to me feels like unnecessary info - it doesn't really mater how it works.
Interested to here @ fengmk2 @ cpojer 's thoughts
Summary
Redefines
vp check --no-lintso it runs Oxlint's--type-check-onlypath whenlint.options.typeCheckis enabled invite.config.ts, and makesvp check --no-fmt --no-lintthe natural type-check-only invocation.Replaces the abandoned PR #1417 approach (sidecar
.mjs+--no-type-checkCLI flag), which conflicts with upstream PR #1378 handing config resolution
back to oxlint/oxfmt.
Related: closes #1275 for the lint-rule-noise-free type-error triage workflow.
Behavior matrix
vp check --no-lint(typeCheck=true)--type-check-only; lint rules suppressedvp check --no-lint(typeCheck=false/missing)vp check --no-fmt --no-lint(typeCheck=true)vp check --no-fmt --no-lint(typeCheck=false)error: No checks enabledwith remediation hintvp check --fix --no-lint(typeCheck=true)--fix+ read-only type-check diagnostics--no-type-checkCLI flag is not introduced — deferred to a follow-up onceoxlint exposes a symmetric OFF-direction flag for type-check.
Key design notes
lint.options.typeAwareandlint.options.typeCheckare true, matching the--type-check/--type-awareflag dependency inrfcs/check-command.md("If
--no-type-awareis set,--type-checkis also implicitly disabled").--fix --no-linton a typeCheck-enabled project runs fmt--fixandthen type-check as read-only diagnostics. On type error, fmt's completion
pass line is still surfaced so lint-staged / pre-commit flows can tell the
working tree was mutated before the failure (previously swallowed).