Open
Conversation
Adds varletjs/varlet (Vue 3 component library) to the ecosystem-ci matrix. Runs upstream's ci.yaml workflow (bootstrap + lint + test:coverage) on ubuntu-only at commit 83f6c6a of the dev branch. Uses forceFreshMigration because the project already lists vite-plus in devDependencies.
✅ Deploy Preview for viteplus-preview canceled.
|
The varlet ecosystem-ci job failed on CI because `node scripts/bootstrap.mjs` spawns `pnpm build` via tinyexec, and `pnpm` is not discoverable by Node's spawn on the runner. Bootstrap silently swallows errors, so internal packages (notably varlet-cli) were never compiled, leading to ERR_MODULE_NOT_FOUND when the test:coverage step later invoked varlet-cli. Replace the bootstrap call with explicit vp run commands that use vp's bundled runtime. Build phase 1/2 packages via -F filters (-r would hit the @varlet/cli <-> @varlet/ui devDependency cycle), then cli/icons/ui-compile sequentially. The cli tsc step reports type errors against @varlet/ui (still unbuilt) but emits JS output, which matches upstream bootstrap behavior.
Previous fix replaced bootstrap.mjs with explicit vp run commands, but that was unnecessarily complex. Simpler: let `vp i -g pnpm` install pnpm into ~/.vite-plus/bin so scripts/bootstrap.mjs (which spawns `pnpm build` via tinyexec) can resolve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node scripts/bootstrap.mjs,vp run lint,vp run test:coverage83f6c6aof thedevbranchforceFreshMigration: truebecause the project already listsvite-plus: catalog:in devDependenciesTest plan
node ecosystem-ci/clone.ts varlet+patch-project.ts varletvp install: 16snode scripts/bootstrap.mjs: 12.9s (builds all internal packages via varlet-cli)vp run lint: 0 warnings / 0 errors on 1128 filesvp run test:coverage: 81 test files, 921 tests passed (10.5s) usingvitest@0.0.0(vite-plus-test)