Repository navigation
fix(session): cancel a queued reconnect when the connection restores itself; release 0.11.8 - #71
Merged
Merged
Conversation
…itself; release 0.11.8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the ICE connection dropped and then recovered on its own while a reconnect attempt was still waiting in its backoff delay, the attempt fired anyway. It rejoined the session and replaced a healthy peer connection. Seen in load tests: the connection was restored at 10:04:30, and the stale attempt replaced it about 2 s later.
Root cause
scheduleAutoReconnectarms a backoff timer. When the original connection recovers first,markRestoredIfRecoveredcleared the recovery timers but not the reconnect timer, so the attempt still ran after the session was already restored.Fix
markRestoredIfRecoverednow clears the pending reconnect timer when the outage was still being recovered via ICE restart (the attempt has not started yet) and logssession/reconnect_cancelled. Attempts already in flight are unaffected.Tests
Two new cases in
browser-voice-session-recovery.test.ts: a restore during attempt 1's backoff creates no new WebSocket or peer connection and leaves the original connection open, and a later outage after a cancelled attempt still reconnects.Release 0.11.8 (version, lockfile, CHANGELOG).
🤖 Generated with Claude Code