Repository navigation
fix(showcase): emit orbit pose at 60 Hz and allow www asset origin - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The orbiting voice demo updated pose at 10 Hz (
ORBIT_TICK_MS50, pose emit 100), so the circle stepped instead of moving smoothly. Position updates now run at 60 Hz for both the mix pose and theorbit_posemessages sent to the page.Clip URLs are resolved only from an allowlisted asset origin. The marketing site (
https://www.voicethere.ioandhttps://voicethere.io) is now on that list, so showcase sounds load when the page is served from the marketing host.Test plan
Verified locally; CI covers
test/spatial-showcase.test.ts. No extra manual steps before merge.This changes the published showcase template. Production picks it up when this package is released and the showcase project is redeployed.