Skip to content

Fix attachment selection bug #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaveLMSP wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix attachment selection bug #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1adafbe
Removing redundant handler
DaveLMSP Apr 7, 2015
165eb28
Fixing attachment selection
DaveLMSP Apr 7, 2015
7280736
Restoring callback
DaveLMSP Apr 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions js/media-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ var MediaModal = function (options) {
},
library : {
type : 'image'
}
},
multiple: false
});

// Set filterable state to uploaded to get select to show (setting this
// when creating the frame doesn't work)
frame.on('toolbar:create:select', function(){
Expand All @@ -39,18 +40,37 @@ var MediaModal = function (options) {
that.settings.cb(attachment);
});

frame.on('open activate', function() {
frame.on( 'open', function() {
// Get the link/button/etc that called us
var $caller = jQuery(that.settings.calling_selector);
var $caller = jQuery( that.settings.calling_selector );

// Select the thumbnail if we have one
if ($caller.data('thumbnail_id')) {
var Attachment = wp.media.model.Attachment;
var selection = frame.state().get('selection');
selection.add(Attachment.get($caller.data('thumbnail_id')));
if ( $caller.data( 'thumbnail_id' ) ) {
var Attachment = wp.media.model.Attachment.get( $caller.data( 'thumbnail_id' ) );
Attachment.fetch();
var selection = frame.state().get( 'selection' );
selection.add( Attachment );

// Overload the library's comparator to push items that are not in
// the mirrored query to the front of the aggregate collection.
var library = frame.state().get( 'library' );
var comparator = library.comparator;
library.comparator = function( a, b ) {
var aInQuery = !! this.mirroring.get( a.cid ),
bInQuery = !! this.mirroring.get( b.cid );

if ( ! aInQuery && bInQuery ) {
return -1;
} else if ( aInQuery && ! bInQuery ) {
return 1;
} else {
return comparator.apply( this, arguments );
}
};
library.observe( selection );
}
});

frame.open();
};

Expand Down