Skip to content

fix(build): add missing build/typecheck scripts and docs - #22

Open
LordMikkel wants to merge 1 commit into
vmlcode:developfrom
LordMikkel:fix/build-scripts
Open

fix(build): add missing build/typecheck scripts and docs#22
LordMikkel wants to merge 1 commit into
vmlcode:developfrom
LordMikkel:fix/build-scripts

Conversation

@LordMikkel

Copy link
Copy Markdown

¿Qué hace este PR?

Corrige bun run build y los comandos relacionados.
Añade scripts de typecheck en packages/shared y backend, y ajusta la documentación para que los comandos sean consistentes.

¿Por qué?

bun run build estaba roto: el script raíz llamaba build en packages/shared y backend, pero esos paquetes no tenían ese script.
Además, packages/shared estaba typecheckeando también tests, y fallaba por errores de tipos de bun:test.

¿Cómo probarlo?

  • Ejecutar bun run build
  • Ejecutar bun run typecheck
  • Ejecutar bun test
  • Revisar que la documentación refleja los comandos actuales

Checklist

  • Los tests existentes siguen pasando (bun test)
  • No toca wire format ni protocolo de malla
  • No toca /ingest ni firma Ed25519

@davgonsan davgonsan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and ran it locally — this is a good, safe fix. bun run build was actually broken before this: the root script fanned out to build scripts in packages/shared and backend that didn't exist, so it always failed. This adds them (+ a typecheck alias) and excludes *.test.ts from tsc.

Verified on the branch:

  • bun run build → clean (typechecks packages/shared + backend)
  • bun run typecheck → clean
  • bun test → 31 pass / 0 fail

One ask: please retarget this to develop, not main. Active development is on develop (that's where the app + backend work is landing), so a build/tooling fix should go there first — otherwise develop keeps the broken bun run build until a main → develop merge catches up. If the intent is main-first, it needs a prompt forward-merge into develop.

LGTM once retargeted.

@LordMikkel
LordMikkel force-pushed the fix/build-scripts branch from e053d50 to 921a5a0 Compare July 2, 2026 00:06
@LordMikkel
LordMikkel changed the base branch from main to develop July 2, 2026 00:06
@LordMikkel

Copy link
Copy Markdown
Author

Thanks! Retargeted to develop and rebased the branch so the PR only contains the build/typecheck fix.

@LordMikkel

Copy link
Copy Markdown
Author

@davgonsan Me gustaría poder seguir aportando al proyecto pero veo que estos últimos días ha parado mucho la actividad y hasta tener estas dos primeras PR no he querido seguir desarrollando, es posible estar en algún grupo o chat de trabajo con ustedes para estar al tanto de como va avanzando el proyecto?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants