Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
243 changes: 123 additions & 120 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/bob-diff-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"devDependencies": {
"@actions/core": "^1.10.1",
"@actions/github": "^6.0.0",
"@actions/github": "^9.1.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rebuild the checked-in action bundle

This action is executed from the committed packages/bob-diff-review/dist/index.js (action.yml points runs.main there), but this commit only updates package.json/package-lock.json and leaves dist/ unchanged. In any workflow that consumes the action directly from the repo, the runtime bundle therefore remains the previous generated payload and does not actually pick up the @actions/github update, so the dependency bump is ineffective until npm run build --workspace @bobnetsec/bob-diff-review is run and the regenerated dist files are checked in.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Switch the GitHub loader off CommonJS require

Bumping to @actions/github 9.1.1 pulls an ESM-only package (type: module with only import exports), but the action entrypoint still loads it with require("@actions/github") in src/action-entrypoint.ts:184. Once the bundle is regenerated, or when the unbundled entrypoint is run with installed dependencies, that CommonJS load path cannot resolve the new package and the action fails before it can read github.context or create an Octokit client; the loader needs to use dynamic import() or stay on a CommonJS-compatible release.

Useful? React with 👍 / 👎.

"@types/node": "^25.9.2",
"@vercel/ncc": "^0.38.3",
"@vitest/coverage-v8": "^4.1.8",
Expand Down
Loading