Reframe pyspark-test-runner default test strategy around grouped runs#15
Merged
Merged
Conversation
The SKILL and README told the agent to pass -x by default, but -x stops pytest at the first failure, so only one failure reaches the JUnit report and the digest's signature dedup has nothing to collapse. That contradicts the digest's headline feature. Make the broad grouped run (no -x) the canonical default and document -x as an opt-in for drilling a single suspected failure. Fix the same bias in the schema success_message, including the whole-suite-plus-stop-at-first smoke-check line. Docs only; the wrapper already defaults -x off and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A
Summary
The
pyspark-test-runnerSKILL and README told the agent to pass-xby default, but-x(--exitfirst) stops pytest at the first failure, so only one failure reaches the JUnit report and the digest's signature dedup has nothing to collapse. That contradicts the digest's headline feature, which the SKILL's owndescriptionsells two sentences earlier. This makes the broad grouped run (no-x) the canonical default and documents-xas an opt-in for drilling a single suspected failure.Docs/guidance only. The wrapper already defaults
-xoff and its code is unchanged.Changes
description, the "Default test strategy" section (two scoped strategies, grouped run as default), the canonical invoke example (dropped-x), the flags-table row, and the FAILED "Reading the result" line.-xfrom the usage example and reframed the usage sentence to match.-xreferences in the post-installsuccess_message, including the whole-suite-plus-stop-at-first smoke-check line.Changedentry under[Unreleased], noting no wrapper behavior change.Change Area
Configuration Axes Affected
Testing
pytest tests/ -V) — 2415 passed, 163 skippedAsset Changes (if applicable)
library/helpers.tmplor other assets)Checklist
.tmplfiles appear in generated output