Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a detailed comment in vime/ray/actor_group.py explaining the performance characteristics and rationale for enabling CPU backup in torch_memory_saver. There are no review comments, so no additional feedback is provided.
0z5a
force-pushed
the
docs/tms-cpu-backup-cost
branch
from
September 24, 2026 05:53
736e22e to
be5306b
Compare
`Actor.sleep()` / `Actor.wake_up()` are the largest single block of a colocate step, and the time is almost entirely `torch_memory_saver`'s CPU-backup copy: measured on 1 GPU colocate with Qwen3-0.6B it moves ~18.7 GiB per step, and the copy path runs at ~2.4 GiB/s while a plain pinned torch copy on the same device does ~24 GiB/s. Note at the point where the mode is chosen that CPU backup is the fastest of the three modes here (disk backup measured ~30x slower on ext4, no backup cannot restore the state), and link the upstream report so the next person to look at this number does not have to re-measure it. No behaviour change; comment only. Signed-off-by: 0z5a <0z5a@users.noreply.github.com> Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
0z5a
force-pushed
the
docs/tms-cpu-backup-cost
branch
from
September 24, 2026 07:07
be5306b to
ba76883
Compare
0z5a
marked this pull request as draft
October 1, 2026 14:31
Author
|
Superseded by #460, now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental review: Files changed.
Base:
0z5a-branchat791f101e20db377b28e15f12a00863baaea2605f.Document the CPU-backup choice at
ActorGroup's memory-saver configuration and link the measured dependency cost to torch_memory_saver#111.CPU backup preserves state; disabling backup cannot restore it. The measured copy cost belongs to the dependency. This PR changes one comment and has no runtime speedup. Offload attribution is in #443, and the existing resident configuration is explained by #445.