Open
Conversation
* update Transport interface to specify onConnOpen and onConnClose callbacks * implement the aforementioned handlers for WebSocketTransport
* extend TransportOptions with 'pingInterval' and 'closeTimeout' (controlling server polling for connection status) * extend WebSocketTransport to poll server for sign of life * extend ws-server (ConnectionBroker) to respond to ping messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to track sync server connectivity:
onConnOpenandonConnClosetoTransportinterfaceWebSocketTransportto implement these methodsCurrent implementation:
onConnCloseis calledThe timeout (how long we wait for sign of life) and interval (poll frequency) are configurable via
pingTimeoutandpingIntervaltransport options (respectively)