Skip to content

bring back IDisposable to the UnitOfWork#9

Open
seanalexander wants to merge 3 commits into
vkhorikov:masterfrom
seanalexander:master
Open

bring back IDisposable to the UnitOfWork#9
seanalexander wants to merge 3 commits into
vkhorikov:masterfrom
seanalexander:master

Conversation

@seanalexander

Copy link
Copy Markdown
Contributor

Used code from "\After" for IDisposable.

Verified the application was still functional.

Verified Performance is still acceptable:
image

Verified there were no open queries during this test using sp_WhoIsActive.

@vkhorikov

vkhorikov commented Dec 23, 2019

Copy link
Copy Markdown
Owner

The Dispose() method should come with a using around UnitOfWork in each command handler, otherwise it'd leak connections too.

@seanalexander

Copy link
Copy Markdown
Contributor Author

I'll update that and repost--I re-used the example from what was in \After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants