Repository navigation
feat(pytest): write failed suite artifacts - #2
Merged
Merged
Conversation
Owner
|
Thanks — LGTM for #1. Opt-in One note vs the issue: you shipped a fixture instead of an auto-write pytest hook — preferable (explicit I/O). Empty suite → no file, which is fine. Happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suite_artifactpytest fixture for writing an indented, stableSuite.to_json()artifact when an eval row failsCloses #1
Verification
PATH="$PWD/.venv/bin:$PATH" .venv/bin/python -m pytest -q— 8 passed.venv/bin/python -m compileall -q src testsgit diff --checkRisk
This is opt-in and uses only the standard library; it does not add required dependencies or affect existing fixtures.