Repository navigation
fix: keep the deprecated alias publishing, and drop the leaked tool id - #157
Merged
Merged
Conversation
Two corrections to P2, both about what a name is FOR. **`@viztor/dsh-opencode` keeps publishing.** P2 retired it (D9), and that is the wrong call for a compatibility name: an install still on it stops resolving the day the name stops publishing, which is the one thing an alias must not do. It is deprecated — the registry message points at the canonical name, the wrapper ships no client half, and nothing in the source tree registers or advertises it — but it publishes, so the installs that still use it keep working. Restored: `scripts/wrapper-forwarder.ts` and its test (the forwarder that LINKS, because the canonical package has no `default` export), the wrapper branch of `publish-scoped.ts`, the alias in `SCOPED_TARGETS`, and the alias in `release.yml`'s verify list — a name that publishes without being verified is how a release reports success while one of its three packages sits behind. `test/package-checks.test.ts` now asserts the opposite of what P2 made it assert: the alias is in both lists, and the publish script names it on purpose. **`.freebuff/project-id` is actually gone.** P1b meant to delete it and the patch emptied the file instead, so `main` carried a zero-byte tracked file — a tool's local project id, still in the tree. Removed, with `.freebuff/` ignored. The READMEs say what is true now: the old name is deprecated and still published, and moving off it is a rename rather than a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to P2, both about what a name is for.
@example-org/dsh-opencodekeeps publishingP2 retired it (D9). That is the wrong call for a compatibility name: an install still on it stops resolving the day the name stops publishing, which is the one thing an alias must not do.
It stays deprecated — the registry message points at the canonical name, the wrapper ships no client half, and nothing in the source tree registers or advertises it — but it publishes, so the installs that still use it keep working.
Restored:
scripts/wrapper-forwarder.tsand its test — the forwarder that links, because the canonical package has nodefaultexport (the defect fix(publish): the retired alias must LINK, not fail on every load #135 fixed);publish-scoped.ts;SCOPED_TARGETS;release.yml's verify list — a name that publishes without being verified is how a release reports success while one of its three packages sits behind.test/package-checks.test.tsnow asserts the opposite of what P2 made it assert: the alias is in both lists, and the publish script names it on purpose..freebuff/project-idis actually goneP1b meant to delete it and the patch emptied the file instead, so
maincarried a zero-byte tracked file — a tool's local project id, still in the tree. Removed, with.freebuff/ignored.Verification
vp checkscripts/check.ts