Conversation
Implement an iterative stretch allocation algorithm for main-axis stretch children: introduce a StretchAlloc record, track remaining_main and remaining_stretch_sum, and freeze items that hit min/max to re-distribute space until settled, then measure children with their computed sizes. Change cross-axis stretch resolution to a two-pass approach (resolve against current estimate, then against the settled line max) using helper closures so cross-stretch children properly adopt the line's final cross size even when min/max constraints determine it. Minor absolute-positioning cleanup: use is_rtl consistently and simplify cross_before/after selection. Tests updated: remove one RTL absolute test and add multiple wrap tests that validate stretch behavior across lines, parent padding, and large min constraints.
Separate RTL checks for row vs column and apply mirroring to the correct axis. Introduce is_column_rtl and use is_row_rtl for main-axis swaps and is_column_rtl for cross-axis swaps when computing absolute child offsets, so only horizontal offsets are mirrored in RTL layouts. Added a clarifying comment and adjusted variable names accordingly. Update layout.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an iterative stretch allocation algorithm for main-axis stretch children: introduce a StretchAlloc record, track remaining_main and remaining_stretch_sum, and freeze items that hit min/max to re-distribute space until settled, then measure children with their computed sizes. Change cross-axis stretch resolution to a two-pass approach (resolve against current estimate, then against the settled line max) using helper closures so cross-stretch children properly adopt the line's final cross size even when min/max constraints determine it. Minor absolute-positioning cleanup: use is_rtl consistently and simplify cross_before/after selection. Tests updated: remove one RTL absolute test and add multiple wrap tests that validate stretch behavior across lines, parent padding, and large min constraints.