Demo: Restore the mjml dependency to fix the welcome mail crash - #6201
Open
VPS-Ricky wants to merge 1 commit into
Open
Demo: Restore the mjml dependency to fix the welcome mail crash#6201VPS-Ricky wants to merge 1 commit into
mjml dependency to fix the welcome mail crash#6201VPS-Ricky wants to merge 1 commit into
Conversation
VPS-Ricky
force-pushed
the
fix-mjml-dependency-demo-site
branch
from
August 13, 2026 13:33
0c5279a to
7b88e9b
Compare
The site does not import `mjml`. It renders mail through `@dextinity/mail-react/server`, which imports `mjml` itself. The entry therefore looks unnecessary, which is why it was removed. It is still needed. Next.js can load a server package at runtime instead of bundling it, but only when the package can be found from the site's own `node_modules`, because that is where the runtime load looks for it. pnpm puts it there only when `package.json` lists it. Without the entry, Next.js bundles `mjml`, and with it `uglify-js`, which reads its own files from disk when it loads and does not find them in the bundle.
VPS-Ricky
force-pushed
the
fix-mjml-dependency-demo-site
branch
from
August 13, 2026 14:30
7b88e9b to
537a936
Compare
VPS-Ricky
marked this pull request as ready for review
August 13, 2026 14:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site does not import
mjml. It renders mail through@dextinity/mail-react/server, which importsmjmlitself. The entry therefore looks unnecessary, which is why it was removed.It is still needed. Next.js can load a server package at runtime instead of bundling it, but only when the package can be found from the site's own
node_modules, because that is where the runtime load looks for it. pnpm puts it there only whenpackage.jsonlists it. Without the entry, Next.js bundlesmjml, and with ituglify-js, which reads its own files from disk when it loads and does not find them in the bundle.