Generate TipTapNode type for rich text blocks - #6200
Draft
VPS-Obi wants to merge 2 commits into
Draft
Conversation
TipTap rich text fields were generated as unknown, so consumers had to cast the content before rendering it. Generate a TipTapNode (and TipTapMark) type matching the one exported by site-react whenever a TipTap rich text block is present, and use it for those fields. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeW8jj95RuXHci5TBJKfKy
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeW8jj95RuXHci5TBJKfKy
VPS-Obi
changed the title
nsams
reviewed
Aug 17, 2026
| attrs?: Record<string, unknown>; | ||
| } | ||
|
|
||
| export interface TipTapNode { |
Member
There was a problem hiding this comment.
duplicating the TipTapNode that is already defined in site-react is not optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves type safety for TipTap rich text blocks by generating proper TypeScript types instead of using
unknown.Changes
TipTapNodeandTipTapMarkinterface definitions to thegenerate-block-typescommand outputunknowntoTipTapNodein generated block typesImplementation Details
isTipTapNodeTypeUsedflag tracks whether any TipTap rich text blocks are presentTipTapNodeandTipTapMarkinterfaces are prepended to the generated content only when neededTipTapNodesupports the full TipTap node structure with optionalattrs,content,marks, andtextpropertieshttps://claude.ai/code/session_01KeW8jj95RuXHci5TBJKfKy