Add environment variable for system user name - #6137
Open
VPS-Obi wants to merge 1 commit into
Open
Conversation
The system user name was hardcoded in the demo API (`SYSTEM_USER_NAME`) and again in the demo site's basic auth headers. Since both sides must agree on the same name, it now comes from a shared environment variable (`BASIC_AUTH_SYSTEM_USER_NAME` for the API, `API_BASIC_AUTH_SYSTEM_USER_NAME` for the site), mirroring how the system user password is already handled. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ci3aLTesK1cDDTVJDe4Xgb
VPS-Obi
changed the title
VPS-Obi
marked this pull request as ready for review
August 6, 2026 13:47
VPS-Obi
requested review from
VPS-thodax,
fraxachun,
kaufmo,
nsams,
vps-dkarnutsch and
vps-manuel-blum
August 6, 2026 13:47
VPS-thodax
approved these changes
Aug 7, 2026
VPS-thodax
added
the
needs-starter-pr
Member
|
I would not do that, this is nothing we will change again as we did in the past. |
fraxachun
approved these changes
Aug 13, 2026
vps-dkarnutsch
approved these changes
Aug 13, 2026
vps-manuel-blum
approved these changes
Aug 13, 2026
kaufmo
approved these changes
Aug 13, 2026
Contributor
Author
"the only constant in life is change". @nsams do you have a strong opinion against it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system user name was hardcoded to
system-userin multiple places. This led to errors when changing the user name (e.g., fromvividtosystem-user). For instance, in a project of ours the name was updated for theAccessLogModule.shouldLogRequestoption, but not for the user itself, resulting in all site build requests being logged.I therefore suggest to make the user name an environment variable and use the variable throughout. Alternatively, we could move the user name to
comet-config.json. Personally, I'd prefer an environment variable though, even if we don't plan on changing the user name for different environments.https://claude.ai/code/session_01Ci3aLTesK1cDDTVJDe4Xgb