cms-admin: Add read-only rendering to the TipTap rich text block - #6119
Merged
Conversation
VPS-Ricky
force-pushed
the
tiptap-rich-text-read-only
branch
4 times, most recently
from
August 5, 2026 10:30
6435fb9 to
f86793f
Compare
VPS-Ricky
force-pushed
the
tiptap-rich-text-read-only
branch
5 times, most recently
from
August 5, 2026 11:00
98f9b9d to
fc11ae8
Compare
VPS-Ricky
marked this pull request as ready for review
August 5, 2026 11:10
VPS-Obi
reviewed
Aug 6, 2026
The first use case will be the table block, which renders a non-editable rich text editor in its admin grid view. The renderer comes from the block because only the block knows what the saved content means: the content stores names, such as a text block style name or a child block key, and the block holds what those names map to. Draft-js can offer a standalone read-only component because it attaches its link and whitespace renderers to the editor state itself. TipTap keeps all of it in the block's configuration, so a renderer without the block shows unstyled text and child blocks as their raw keys.
The read-only story used a block with no text block styles configured, so it could not tell a correctly resolved style apart from having none to resolve.
VPS-Ricky
force-pushed
the
tiptap-rich-text-read-only
branch
from
August 10, 2026 23:01
93cce33 to
20ef3d1
Compare
VPS-Obi
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first use case will be the table block, which renders a non-editable rich text editor in its admin grid view.
The renderer comes from the block because only the block knows what the saved content means: the content stores names, such as a text block style name or a child block key, and the block holds what those names map to. Draft-js can offer a standalone read-only component because it attaches its link and whitespace renderers to the editor state itself. TipTap keeps all of it in the block's configuration, so a renderer without the block shows unstyled text and child blocks as their raw keys.
Task: https://vivid-planet.atlassian.net/browse/COM-3096