Skip to content

fix: prevent node builtins double prefix (fix #10630)#10767

Merged
sheremet-va merged 1 commit into
vitest-dev:mainfrom
malobre:main
Jul 17, 2026
Merged

fix: prevent node builtins double prefix (fix #10630)#10767
sheremet-va merged 1 commit into
vitest-dev:mainfrom
malobre:main

Conversation

@malobre

@malobre malobre commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fix #10630

Description

Some node builtins are natively prefixed and get prefixed a second time.

This should probably get a unit test, but I'm strained for time and the contributing doc did not have a lot of information on tests (test/README.md also seems a bit outdated).

Resolves #10630

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va
sheremet-va merged commit 22d353a into vitest-dev:main Jul 17, 2026
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vitest double-prefixes node:-only built-ins in resolve.external

2 participants