Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
7 tasks
vite-light.svg and vite-dark.svg use 15 <feGaussianBlur> filters plus an alpha mask to render the lightning-mark gradient glow. WebKit rasterizes these filter/mask effects differently than Chromium at small icon sizes (~24px), producing blur, color bleeding, and incorrect edges - Chrome renders the same files correctly. Replace the runtime filter/mask stack with a single pre-rasterized PNG (10x the viewBox resolution) embedded via <image>, so both files render identically across browsers regardless of filter/mask rasterization differences, with no filter/mask processing needed at all. File paths, extensions, and viewBox stay the same so nothing downstream needs to change. This matches the fallback VitePress already adopted for the same files in vuejs/vitepress#5466. Fixes vitejs#23588
neevmodh
force-pushed
the
fix/logo-svg-webkit-rendering
branch
from
September 26, 2026 08:48
b88b4dd to
3fd9f49
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite-light.svg/vite-dark.svgbuild the lightning-mark gradient glow from 15<feGaussianBlur>filters plus an alpha<mask>. WebKit rasterizes this filter/mask stack differently than Chromium at small icon sizes (~24px), producing blur, color bleeding, and incorrect edges, while Chrome renders the same files correctly.<image>. Both files then render identically across browsers since it's a plain image blit, with no filter/mask processing at all.viewBoxare unchanged, so no downstream consumer needs to update anything.Test plan
viewBox="0 0 87 15"so nothing downstream needs updating.Fixes #23588