Conversation
Comicao1
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23472.
The
image-set()rewriting broke on candidates with nested functions, e.g.linear-gradient(to right, rgba(0,0,0,0), rgba(0,0,0,1)). Two regexes were hitting the classic "can't match balanced parens" problem:cssImageSetREstopped theimage-set(...)capture at the first inner), so the candidate list got truncated and the trailing descriptor was left danglingparseSrcsetthen also split such candidates at the inner commasReplaced both with a small paren-aware scanner (quote and escape handling included). Behavior for
-webkit-image-set(), commas inside unquoted urls, and unbalanced input is unchanged.Added unit tests for
rewriteCssImageSet(nested functions, webkit prefix, multiple occurrences, unbalanced input) and forparseSrcsetwith nested candidates. Fullpackages/viteunit suite passes (942 tests), lint + typecheck clean.