Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this testing Nuxt from a directory whose name contains a space. to be fair, I was trying to get errors (testing nuxt/nuxt#36258).
... and lo and behold, I did! any error thrown from a module evaluated by the module runner loses its file name entirely:
the same project at a path without a space shows
at boom (/.../app/utils/boom.ts:2:9)V8 only reads the module id up to the first whitespace character (see scanner source), but we previously just wrote the raw module id after
//# sourceURL=this PR percent-encodes just the whitespace when writing the directive, and decodes it back in the two places that turn a frame's file back into a module id (
getRunnerSourceMapin the interceptor, andssrRewriteStacktraceforssrFixStacktrace).I decide to encode rather than
pathToFileURLbecause both lookups key off the raw id, and afile://sourceURL might need a wider id normalisation.but you may have a different suggestion 🙏