fix(server): handle file watcher errors without crashing - #23503
Open
kingmakeruix wants to merge 3 commits into
Open
kingmakeruix wants to merge 3 commits into
kingmakeruix wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Log chokidar watcher errors as a warning instead of letting the uncaught error event crash the dev server. ## Why createServer subscribes to change/add/unlink but never error, so any watcher failure (e.g. EBUSY on a briefly locked file on Windows) kills vite dev. Closes #23470. ## How - Added watcher.on(error) in _createServer that warns via config.logger - Added regression test in packages/vite/src/node/tests/plugins/hooks.spec.ts ## Checklist - [x] Tests pass locally (hooks.spec.ts 25/25; new test fails without the fix) - [x] lint clean Note: prepared with AI assistance under my direction.