fix: suppress customizable select warning - #836
Open
jibin7jose wants to merge 1 commit into
Open
jibin7jose wants to merge 1 commit into
jibin7jose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR solving?
This PR fixes a false-positive warning for customizable
<select>markup invite-plugin-vue. Valid<option>content was being reported as invalid HTML even though it is allowed by the modern customizable select pattern.Fixes #828
What other alternatives have you explored?
I considered suppressing all
<option>warnings, but that would be too broad. This change keeps the fix narrow and only filters the specific false-positive case.Are there any parts you think require more attention from reviewers?
Please review the warning-matching logic to make sure it only suppresses the customizable select case and does not hide unrelated compiler warnings.
Tests
I added a regression fixture and a test that reproduces the customizable select case and verifies the warning is no longer emitted.