Modernized CMakeLists.txt, removed deprecated CGAL macros, made LEDA-…#4
Open
DhruvTotala wants to merge 1 commit intovissarion:developfrom
Open
Modernized CMakeLists.txt, removed deprecated CGAL macros, made LEDA-…#4DhruvTotala wants to merge 1 commit intovissarion:developfrom
DhruvTotala wants to merge 1 commit intovissarion:developfrom
Conversation
…dependent targets optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates and cleans up the CMake build configuration to make the project compatible with modern CMake and CGAL versions.
The original build system relied on deprecated CGAL helper macros and older CMake practices, which caused build issues on newer systems. This update replaces those legacy patterns with modern, target-based CMake commands to improve maintainability and portability.
Additionally, the build previously required the LEDA library unconditionally. Since LEDA is not commonly available and caused compilation failures, this change makes LEDA optional. If LEDA is not found, LEDA-dependent targets are skipped, allowing the rest of the project to build successfully.
These changes make the project easier to compile on modern Linux environments and improve overall build reliability without modifying the core functionality.
The build was tested on Ubuntu 22.04 (WSL) using CGAL 5.x.