Skip to content

Fix deserialize buffer ownership on failure - #83

Merged
vinzenz merged 1 commit into
masterfrom
t3code/resolve-issue-52
Sep 13, 2026
Merged

vinzenz merged 1 commit into
masterfrom
t3code/resolve-issue-52

Conversation

@vinzenz

@vinzenz vinzenz commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Correct buffer ownership handling when SQLite deserialization fails.
  • Report unavailable deserialization APIs with a clear exception.
  • Add regression coverage for memory retention and connection usability.
  • Remove the outdated CodeRabbit badge from the README.

Testing

  • Added FailingDeserializeThrowsCatchablyAndRetainsNoMemory regression test.
  • Verifies failed deserialization does not leak or retain the image buffer.
  • Verifies the destination connection remains usable after failure.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b177cf01-fd3a-49f6-9446-335725794252

📥 Commits

Reviewing files that changed from the base of the PR and between d8a2ba1 and 0654008.

📒 Files selected for processing (2)
  • src/sqlite/serialization.cpp
  • tests/test_serialization.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vinzenz

vinzenz commented Sep 10, 2026

Copy link
Copy Markdown
Owner Author

@codex review this

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-10T17:03:59.589135Z 0654008 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 0654008c22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vinzenz

vinzenz commented Sep 12, 2026

Copy link
Copy Markdown
Owner Author

@deslopify

@vinzenz

vinzenz commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@deslopify rerun

- Throw clearly when SQLite serialization APIs are unavailable
- Verify failed deserialization frees buffers without leaks
@vinzenz
vinzenz force-pushed the t3code/resolve-issue-52 branch from 0654008 to 6540759 Compare September 13, 2026 19:38
@vinzenz
vinzenz merged commit 434b213 into master Sep 13, 2026
18 of 19 checks passed
@deslopify

deslopify Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review request received. The standard review is completed. Use @deslopify rerun to request a new attempt once this one finishes.

@vinzenz
vinzenz deleted the t3code/resolve-issue-52 branch September 19, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant