Reset statements before caching to release locks

[vinzenz]

Summary

• Reset and clear bindings before retaining statements in the cache.
• Finalize statements whose reset reports an error instead of caching them.
• Add regression coverage for released read locks, cursor reuse, bindings, and failed statements.
• Remove the CodeRabbit badge from the README.

Testing

• Added statement cache regression tests covering mid-cursor returns, early range exits, unfinished aggregates, reuse, bindings, and step failures.
• Not run.

Summary by CodeRabbit

• Bug Fixes

  • Improved SQLite statement handling to release read locks when operations stop before completion, preventing them from blocking writes.
  • Ensured cached statements restart cleanly and do not retain previous parameter bindings.
  • Statements that fail during execution are no longer retained for reuse.

• Tests

  • Added regression coverage for interrupted queries, unfinished aggregates, binding cleanup, statement reuse, and execution failures.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4007ced2-43c0-4519-a2f8-bf111a7b90f1

📥 Commits

Reviewing files that changed from the base of the PR and between d8a2ba1 and 28ea72e.

📒 Files selected for processing (3)

• include/sqlite/statement_cache.hpp
• src/sqlite/statement_cache.cpp
• tests/test_statement_cache.cpp

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/address-reported-bug

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vinzenz]

@claude review this

[vinzenz]

@deslopify

[vinzenz]

@deslopify rerun

[deslopify]

Review request received. The standard review is completed. Use @deslopify rerun to request a new attempt once this one finishes.