Skip to content

Fix SQLITE_SERIALIZE_NOCOPY buffer ownership - #78

Merged
vinzenz merged 1 commit into
masterfrom
t3code/resolve-issue-53
Sep 13, 2026
Merged

vinzenz merged 1 commit into
masterfrom
t3code/resolve-issue-53

Conversation

@vinzenz

@vinzenz vinzenz commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve SQLite-owned buffers returned with SQLITE_SERIALIZE_NOCOPY.
  • Document no-copy behavior and errors for unavailable in-memory images.
  • Add coverage for database usability, image parity, and file-backed failures.

Testing

  • Added serialization tests for no-copy ownership and connection usability.
  • Verified no-copy output matches the owning-copy image.
  • Verified file-backed databases throw for SQLITE_SERIALIZE_NOCOPY while remaining usable.

Fixes #53

- Preserve SQLite-owned buffers returned by SQLITE_SERIALIZE_NOCOPY
- Document and test no-copy behavior and file-backed database failures
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: dc1bdfd4-5d14-4067-994f-30fc7be0e993

📥 Commits

Reviewing files that changed from the base of the PR and between d83b6a5 and 6ef4ac5.

📒 Files selected for processing (3)
  • include/sqlite/serialization.hpp
  • src/sqlite/serialization.cpp
  • tests/test_serialization.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vinzenz

vinzenz commented Sep 12, 2026

Copy link
Copy Markdown
Owner Author

@deslopify

@vinzenz

vinzenz commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@deslopify rerun

@vinzenz
vinzenz merged commit ecfe2af into master Sep 13, 2026
20 checks passed
@deslopify

deslopify Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review request received. The standard review is completed. Use @deslopify rerun to request a new attempt once this one finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] serialize with SQLITE_SERIALIZE_NOCOPY frees the live database buffer

1 participant