fix(deps): patch form-data, multer, and nodemailer security advisories - #97
Merged
Merged
Conversation
Trivy has failed on main since 2026-06-22 with three HIGH advisories: - form-data 4.0.5, CVE-2026-12143 (form field override via CRLF injection), transitive via axios which still pins 4.0.5 on its latest release - multer 2.1.1, CVE-2026-5079 (DoS via deeply nested field names), transitive via @nestjs/platform-express - nodemailer 8.0.7, GHSA-p6gq-j5cr-w38f (raw option bypasses disableFileAccess / disableUrlAccess) The first two are transitive with no fixed parent release, so they are pinned via overrides, matching the approach already used for qs and fast-uri. nodemailer is a direct dependency and needs the 9.x major. Nodemailer 9's breaking changes do not reach this codebase: they cover the raw message option, TLS validation when fetching remote content, and url.parse. The email notifier only calls createTransport with SMTP settings and sendMail with a subject and html body — no raw option, no attachments, no remote content. Verified with Trivy 0.70.0 using the same flags CI runs: 3 HIGH before, 0 after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainsince 2026-06-22.form-dataandmulterare transitive with no fixed parent release, so they are pinned viaoverrides— the same approach already used forqsandfast-uri.nodemaileris a direct dependency and needs the 9.x major.Type of Change
fix— Bug fixWhy the nodemailer major is safe here
9.0.0's breaking changes are the
rawmessage option, TLS validation when fetching remote content, and replacingurl.parse.EmailNotifierAdapteronly callscreateTransportwith SMTP settings andsendMailwith a subject and an html body — noraw, no attachments, no remote content fetching. None of the changed surfaces are reachable from this codebase.Test Plan
npm test) — 569 tests, 65 suitesnpm run build)npm run lint:check)fs --severity CRITICAL,HIGH --ignore-unfixed --exit-code 1): 3 HIGH before → 0 after, exit 0Notes