Fix missing i18n translations in admin UI and custom sections#162
Merged
Conversation
Several user-visible strings in public/shared/admin.js bypassed the i18n system and stayed in English regardless of the user's selected locale, also leaking into browser-printed PDFs. The admin-side renderer had drifted from the public-side renderer in public/shared/scripts.js, which already routed the same strings through t(...). Affected: - "View →" link on grid- and list-layout custom-section items. - "Learn More →" link on cards-layout custom-section items. - "Manage Items" button on every custom section. - title tooltips on per-row Toggle Visibility / Edit / Delete / drag-handle controls across Experience, Certifications, Education, Skills, Projects, and custom-section item rows. All call sites now go through t(...). Reused existing keys view_link, learn_more, and action.toggle_visibility; added action.manage_items, action.edit, action.delete, and action.drag_to_reorder to all 8 locale files so key parity (enforced by tests/frontend.test.js) is preserved. Fixes #161 https://claude.ai/code/session_01NTce1xfN8xiRcHWqoZaeV5
vincentmakes
force-pushed
the
claude/analyze-hardcoded-text-OGa8v
branch
from
330027b to
c4d1061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes hardcoded English strings in the admin interface that were bypassing the i18n system and appearing in English regardless of the user's selected locale. The issue affected:
t('view_link')andt('learn_more')These strings also leaked into browser-printed PDFs, showing English text regardless of locale selection.
Type of Change
Changes Made
public/shared/admin.jswitht(...)callsaction.manage_itemsaction.editaction.deleteaction.drag_to_reorderview_link,learn_more,action.toggle_visibilitypackage.jsonandversion.jsonChecklist
npm testpasses)package.json,package-lock.json,version.json)CHANGELOG.mdhas been updated with new entriest('key')instead of hardcoded Englishtests/frontend.test.js)Test Plan
Existing frontend tests verify i18n key parity across all 8 locale files. The changes ensure that:
https://claude.ai/code/session_01NTce1xfN8xiRcHWqoZaeV5