Repository navigation
Preserve sparse edits when selecting DataFrame rows - #332
Merged
vincentlaucsb merged 1 commit intoOct 6, 2026
Merged
Conversation
fhgffy
marked this pull request as ready for review
October 5, 2026 05:47
Contributor
Author
Owner
|
Thanks for the PR |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve existing sparse cell edits when
DataFrame::selected_rows()builds a filtered, unkeyed frame. The current implementation shares parsedCSVRowstorage and carries the visible column mapping, but omits the selected rows' edit overlays, silently reverting edited cells to their original parsed values.The fix snapshots each selected nonempty overlay under its existing lock and stores it independently in the result. Parsed row bytes remain shared; physical column indices and column-name policy are preserved. Later edits to either frame remain independent.
Regression coverage
Validation
The new tests fail on unmodified production base
5a7cc8ff97d23f475adb220f6d268cfd4f843ea2for the intended loss-of-edits symptom. Validation on GCC 14.2.0 / Linux x86_64:MSVC, Clang, other operating systems, ThreadSanitizer and successful leak detection were not tested. Independent review approved the exact final tree.