Non-blocking send queue on EAGAIN - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Outbound send queue on EAGAIN
Summary
Replace the single deferred packet buffer with a per-player outgoing queue so sends remain ordered and non-blocking. Packets are sent immediately when possible and queued only when the socket returns
EAGAIN/EWOULDBLOCK.Key changes
out_packet_tand per-player queue pointers ininclude/UCraft/player.h, removing the legacypacket_dispatch_eventpath.sendData()to report blocking via an out param and return early onEAGAIN/EWOULDBLOCK.src/socketio.c, with cleanup of queued packets insrc/player.c.src/UCraft.ctosendDispatch()+sendFlush().errnoinclude toinclude/UCraft/wrapper_unix.handinclude/UCraft/wrapper_win.hafter removing it frominclude/UCraft/socketio.h.Behavior
sendDispatch()sends immediately and does not queue.sendFlush().Note
AI assistance was used during the implementation (codex). Human intervention was involved though!