WIP: Introduce a new package named containerd#1
Open
vikramhh wants to merge 2 commits into
Open
Conversation
vikramhh
changed the title
Owner
Author
|
This is a WIP - most of the debugging stuff will be removed along with some of the newly introduced unused variables [or they will be used in the next checkin]. I verified end to end scenarios around Find-Package and Install-Package with the provider. |
vikramhh
force-pushed
the
introduce_containerd_package
branch
from
October 3, 2019 22:35
b652b6c to
906d490
Compare
StefanScherer
left a comment
StefanScherer
left a comment
There was a problem hiding this comment.
Only a duplicate variable so far.
In the meantime I tried to setup a test environment to test installation. I'll ask some questions about the artifacts in a different channel.
vikramhh
force-pushed
the
introduce_containerd_package
branch
2 times, most recently
from
October 10, 2019 23:54
fbdf6dd to
0e30f27
Compare
vikramhh
force-pushed
the
introduce_containerd_package
branch
from
October 17, 2019 01:01
0e30f27 to
6ae1144
Compare
1. Restructure code to make it easier to have multiple packages. 2. Introduce the containerd package 3. Introduce implicit links between a package and its source's names (a source for a given package should start with that package's name) 4. Handle multiple names and wildcards in package name specification 5. Installation of the containerd service. 6. Removal of redundant/duplicated code and bug fixes for issues encountered while making changes. Pending: 1. Specification and handling of Dependencies - future work. Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
vikramhh
force-pushed
the
introduce_containerd_package
branch
from
January 29, 2020 20:55
6ae1144 to
14f0724
Compare
The default installation of Docker [without specifying a version number] should lead to installation of the containerd package as well. Signed-off-by: vikrambirsingh <vikrambir.singh@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
names (a source for a given package should start with that
package's name)
specification
Pending:
in short order.
Signed-off-by: Vikram bir Singh vikrambir.singh@docker.com