Repository navigation
chore(deps): bump views-frames to >=1.10.2,<2 — verified wire-byte-identical first - #209
Merged
Merged
Conversation
…entical first views-frames sits on the byte-producing path: wire/shard.py writes each Hop-B shard through views_frames.io.arrow.save, and the §10 golden fixture is generated the same way. A version bump there is a candidate contract event, so it was checked rather than assumed. Verified in a clean venv at pyarrow 16.1.0 (the pinned version, not this machine's 23.0.1) with views-frames 1.10.2: the fixture generator reproduces ALL FIVE canonical artifacts byte-identically — arrow shard, tap zip, both manifests, sidecar. The committed SHA256SUMS is unchanged and the fixture bytes are untouched. The same venv runs the full suite at 312 passed, 0 failed. The five failures seen locally are purely this machine's pyarrow 23.0.1 against the <17 pin (C-72); they disappear at the pinned version, which is a useful confirmation that the known-failure set really is what it has been claimed to be all along. Lock diff is one package: 1.6.0 -> 1.10.2 plus a docs extra that appeared in the new release's metadata. pyarrow stays at 16.1.0. views-frames 1.10.2 declares pyarrow>=14,<20 for its arrow extra, so the ceiling is compatible. Also corrects the fixture README, which named views_frames 1.0.0 as a pinned tool version. That was stale — the lock had said 1.6.0 for weeks — and it conflated the two dependencies. pyarrow is the version-sensitive one; views_frames is not, and the README now says which is which and what evidence supports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
views-frames = ">=1.0,<2"→">=1.10.2,<2". Lock moves 1.6.0 → 1.10.2.Why this needed checking rather than just doing
views-frames is on the byte-producing path.
wire/shard.py:34writes every Hop-B shard throughviews_frames.io.arrow.save, and the §10 golden fixture is generated the same way. A bump there is a candidate ADR-013 contract event — the thing epic #181 held frozen for eleven stories.Verified, in a clean venv at the pinned pyarrow
Built a throwaway venv with pyarrow 16.1.0 (the pinned version — not this machine's 23.0.1) and views-frames 1.10.2, then re-ran the fixture generator and compared every artifact:
All five byte-identical.
SHA256SUMSunchanged, fixture bytes untouched,contract_versionstill1.5.The same venv runs the full suite: 312 passed, 0 failed.
A useful side-confirmation
The five failures seen on this machine are purely pyarrow 23.0.1 against the
<17pin (C-72). At the pinned version they disappear entirely. That has been asserted all session as "known-acceptable, CI authoritative" — this is the first time it has been demonstrated directly rather than inferred from CI staying green.Compatibility
views-frames 1.10.2 declares
pyarrow>=14,<20for itsarrowextra. Our>=16.1.0,<17.0.0sits inside that. Lock diff is one package plus adocsextra that appeared in the new release's metadata; pyarrow does not move.Fixture README corrected
It named
views_frames 1.0.0as a pinned tool version — stale (the lock had said 1.6.0 for weeks) and conflating two dependencies. It now says which one is version-sensitive and what evidence supports the claim:That last sentence is ADR-014 §1 applied to the next person doing this.
🤖 Generated with Claude Code