Repository navigation
fix(fixture): commit the golden-fixture byte artifacts .gitignore silently excluded - #102
Merged
Merged
Conversation
…ket *.zip/*.parquet ignore silently dropped PR #100 claimed to publish the ADR-013 §10 canonical bytes, but .gitignore's blanket rules excluded the Track-A shard zip and both parquets — only the JSON manifests, SHA256SUMS, and README actually landed. CI on development has been red since the merge (wire-fixture tests + PR #101 collection fail on the missing files). Adds a scoped un-ignore rule (same pattern as the ADR-011 lookup exception) and the three verified files (sha256sum -c SHA256SUMS: OK — bytes unchanged, root hash b1f3878d… intact). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
PR #100 published the ADR-013 §10 golden fixture — but
.gitignore's blanket*.zip/*.parquetrules silently excluded 3 of the 7 files (the Track-A shard zip, the arrow shard, the sidecar parquet). Only the JSON manifests,SHA256SUMS, and README were actually committed. The canonical bytes existed on one machine only.Consequence:
Run Pytestondevelopmenthas been red sincefc873b6(the #100 merge) — the wire-fixture conformance tests fail on the missing files, and PR #101 fails at collection for the same reason. PR #100 was merged despite that failing check — a process miss, recorded here.Fix
!tests/fixtures/wire_contract/*(same pattern as the existing ADR-011gaul_lookup.parquetexception — the fail-loud fix, so regeneration can never silently drop the bytes again).sha256sum -c SHA256SUMS→ all OK. Bytes unchanged; the pinned root hashb1f3878d…is intact, so nothing that cited it moves.Verification
CI on this PR is the proof: the 7 wire-fixture tests can only pass with the bytes present.
Refs: ADR-013 §10, PR #100, PR #101.
🤖 Generated with Claude Code