Skip to content

C2 — Retire views_postprocessing/reconciliation/ (moved to views_frames_reconcile) #62

Description

@Polichinel

Cross-repo cutover for views-frames Epic 11 (views-platform/views-frames#131). blocked on C1 (views-models repoint). Closes #31.

Problem

The reconciler has moved to the views_frames_reconcile sibling in the views-frames distribution and consumers are repointed (C1). views-postprocessing was only ever a way-station — FAO delivery doesn't use reconciliation. Delete our copy so the repo screams its real job (partner delivery).

Work

  • Delete views_postprocessing/reconciliation/ (proportional.py, grouping.py, frames.py, validation.py, module.py, init.py).
  • Delete its tests tests/test_reconciliation_*.py, fixtures tests/fixtures/reconciliation_*.npz, and scripts/gen_reconciliation_*.py.
  • vpp deps unchanged (already depends on views-frames; no new dep — vpp does not consume the reconciler).
  • Update docs/CICs/ReconciliationModule.md + the migration notes to point at views-frames; move register C-37/C-38 tracking to views-frames.

Acceptance criteria

Dependencies

  • Blocked on C1 (consumer must import from views-frames first).
  • Only proceed once views-frames#137 (v1.7.0) is released, C1 merged, and CI green — release → repoint → delete order.

Files

delete views_postprocessing/reconciliation/, tests/test_reconciliation_*.py, tests/fixtures/reconciliation_*.npz, scripts/gen_reconciliation_*.py; update docs/CICs/ReconciliationModule.md.

Activity

  1. added
    storyA single reviewable unit of an epic
    blockedBlocked on a dependency or decision
    on Jun 26, 2026
  2. added 2 commits that reference this issue on Jun 26, 2026
  3. Polichinel commented on Jun 26, 2026

    @Polichinel
    CollaboratorAuthor

    Done in PR #63 (merged to development 2026-06-26, merge commit c9e3840). Deleted views_postprocessing/reconciliation/ (6 modules) + 6 tests + 2 parity fixtures + 2 gen scripts + the ReconciliationModule CIC; migration doc → pointer to views-frames; dropped the stale CIC-index entry (review fix). ruff + pytest green (74 passed / 43 xfailed); CI (check-branch, Analyze, CodeQL) green.

    Deletion-safety verified on origin/development pre-merge: no unguarded importer of views_postprocessing.reconciliation anywhere — C1 (views-models#191) had already repointed reconciler_factory to views_frames_reconcile (PR #202); only guarded pytest.importorskip tests remain (skip when absent). (Closes didn't auto-fire: PR targeted development, not the default branch.)

  4. Polichinel commented on Jun 26, 2026

    @Polichinel
    CollaboratorAuthor

    ✅ Unblocked — the reconciliation cutover landed (Decision K)

    The reconciler's live home is now `views_frames_reconcile` (views-frames v1.7.0 sibling). views-pipeline-core PR #217 merged to `development` (`6427b9d`, 2026-06-26): pipeline-core reconciles via its `Reconciler` port, and views-models (`reconciler_factory`) constructs + injects `views_frames_reconcile.ReconciliationModule`. Nothing imports vpp's `reconciliation/` copy — it's a stranded way-station (vpp was only ever a parity oracle; FAO delivery doesn't reconcile).

    Note: this is Decision K, not the earlier C plan — but it doesn't change C2's premise. vpp's reconciliation copy is dead either way, so this issue proceeds as written: delete `views_postprocessing/reconciliation/` + its tests/fixtures/scripts, and repoint `docs/CICs/ReconciliationModule.md` at `views_frames_reconcile`. (The earlier "blocked on C1 / views-models repoint" gate is satisfied — views-models already imports `views_frames_reconcile`.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedBlocked on a dependency or decisionimplementationCode implementation workstoryA single reviewable unit of an epic

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions