Skip to content

S3 — Finish #158's rename, and ban the retired contract name from code #184

Closed

Description

@Polichinel

Part of epic #181. Finishes #158, which was closed 2026-08-01 without the work being done.

Background

The platform's cross-repo seam contract was renamed on 2026-07-31. The registry says so itself:

[meta]
contract = "The Appwrite Seam Contract"
former_contract_name = "PLATFORM-001"   # retired 2026-07-31 by ADR-011
version = "1.3.0"

Issue #158 — "Rename PLATFORM-001 → The Appwrite Seam Contract in this repo's citations" — was filed for it and closed on 2026-08-01. The documentation half landed. The code half did not:

$ grep -rn "PLATFORM-001" --include=*.py .
views_postprocessing/unfao/appwrite_env.py:3    # module docstring
views_postprocessing/unfao/appwrite_env.py:48   # inside the raised error message
tests/test_redaction_guard.py:2                 # docstring
tests/test_env_declaration.py:100               # comment

Line 48 is the one that matters. It is in the text of a raised exception — the message an operator reads when a delivery refuses to launch. It points them at a contract name that no longer exists, in a repo they do not own, on the day their run failed.

This is the same drift class as S2, arriving through the other door: S2 is the register says open, the code says fixed; this is the issue says done, the code says otherwise. Both are claims with nothing checking them.

Work

  1. Replace all four PLATFORM-001 references with The Appwrite Seam Contract. Keep each sentence's meaning; the registry is still referenced, never copied, and appwrite_env.py:48 must still tell the operator where coordinates come from and that the secret is the operator's slot.
  2. Where a reference is load-bearing (the docstring at :3 and the error at :48), also cite the pinned URL to views-appwrite/docs/ADRs/platform/coordinate_registry.toml at a commit, per this repo's standing cross-repo rule (CLAUDE.md: "referenced by URL at a pinned commit, never copied"). Get the sha with git -C ../views-appwrite rev-parse --short HEAD.
  3. Add a test banning the retired name from code.

Do not rename anything in docs/ADRs/ that records the historical name as history — an ADR describing what was decided on a date correctly uses the name in force then. Only citations that claim to name the current contract change. Check each of the four before editing.

Acceptance criteria

  • grep -rn "PLATFORM-001" --include=*.py . returns nothing.
  • The raised message in assert_env_declared names the current contract and a pinned URL.
  • Historical ADR text is untouched; only present-tense citations change.
  • A test fails if the retired name returns to .py files.

Testing

The pattern already exists in this repo: tests/test_doc_accuracy.py:29 bans the word geopandas to keep C-39's deletion from silently reverting. Mirror it.

def test_the_retired_contract_name_is_gone_from_code():
    """PLATFORM-001 was retired 2026-07-31. A citation naming it points an
    operator at a contract that no longer exists (#158)."""
  • Scan views_postprocessing/**/*.py and tests/**/*.py.
  • Assert zero hits, with a message naming the file so the failure is actionable.
  • Deliberately exclude docs/ — historical ADR text is allowed to say it.

Validation:

ruff check .
grep -rn "PLATFORM-001" --include=*.py .    # must be empty
pytest -q tests/test_env_declaration.py tests/test_redaction_guard.py tests/test_doc_accuracy.py
pytest -q

Dependencies

None. Blocks S6, which touches the same module and must not conflict.

Files

Activity

  1. added
    storyA single reviewable unit of an epic
    testingTest/parity/validation work
    on Aug 1, 2026
  2. added a commit that references this issue on Aug 2, 2026
  3. Polichinel commented on Aug 2, 2026

    @Polichinel
    CollaboratorAuthor

    Landed in #195.

    Four PLATFORM-001 citations removed from code, and the URL that #158's find-and-replace broke is fixed: ADR-013 §7d pointed at a path containing spaces that had never resolved. Both §7d links now pinned to views-appwrite b54928f (registry v1.4.0) rather than tracking main. Recorded as Erratum E2; contract_version stays 1.5.

    Ban test scans the package, tests and scripts/ — review caught that two roots would have been register C-74's defect committed again. Mutation-tested at the widened scope.

    Register: 74 concerns, 22 open.

  4. added a commit that references this issue on Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    implementationCode implementation workstoryA single reviewable unit of an epictestingTest/parity/validation work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions