Repository navigation
ADR-008 compliance: add log-before-raise to remaining raises (C-19) #13
Description
Activity
- added a commit that references this issue
on Jun 24, 2026 Status vs current
development(2026-06-27): scope much reduced.- mapping.py is deleted (C-39) → the 20 mapping.py raises are moot.
- unfao.py current raises: lines 70, 80, 108, 177, 182, 189, 194, 287.
- Compliant (explicit log-before-raise): 177/182/189/194 (the
_validatenull/missing-column gates). - Logged via enclosing try/except: 108 (
FileNotFoundError, inside_read_forecast_data's try that doeslogger.error(...); raise). - Still lacking any log-before: 3 raises — :70 (missing
ensemble), :80 (missingloa), :287 (datasets None in_save).
- Compliant (explicit log-before-raise): 177/182/189/194 (the
- New
delivery/invariants (coverage/identity/observed_range) raise representation-free by design; their manager call sites log context first (e.g._check_coverage,_read_forecast_dataidentity log).
Residual = the 3 manager raises above. Mechanical fix, Tier 3.
- added a commit that references this issue
on Jun 27, 2026 Fixed and merged to
developmentvia #68 — the 3 manager raises now log-before-raise; the 20 mapping.py raises were moot (mapping.py deleted, C-39). Manager CIC §3 synced. Closing manually (auto-close keyword doesn't fire ondevelopmentmerges).
Context
ADR-008 requires structural failures to be both logged persistently AND raised explicitly. Currently:
logger.error(3 validation methods were fixed)logger.error(lines 65, 75, 225)When exceptions are caught by batch handlers (which log at ERROR and continue), the original raise is NOT logged — the failure is both swallowed AND unrecorded.
Requirements
logger.error(err_msg)before eachraise ValueError(err_msg)in both files_validate(): construct err_msg, log it, raise with itRisk Register
C-19 (Tier 3). Part of Cluster B.
Note
If ADR-011 eliminates mapping.py from runtime, the 20 mapping.py raises become moot. The 3 unfao.py raises remain relevant regardless.