docs(design): add PlaybackRates design#1572
Closed
ronald-urbina wants to merge 2 commits into
Closed
Conversation
|
@ronald-urbina is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 43022e4 |
ronald-urbina
changed the title
spuppo-mux
reviewed
Jun 16, 2026
Comment on lines
+62
to
+71
| interface MediaPlaybackRateState { | ||
| /** Derived — the effective list the UI reads. Never set directly. */ | ||
| readonly playbackRates: readonly number[]; | ||
| /** Set by the root player — consumer intent. */ | ||
| readonly requestedRates: readonly number[]; | ||
| /** Set by source plugins — null when unconstrained. */ | ||
| readonly sourceRates: readonly number[] | null; | ||
| /** Currently active rate. */ | ||
| readonly playbackRate: number; | ||
| } |
Collaborator
There was a problem hiding this comment.
comment: on first read I didn't understand what sourceRates meant (from what I understand, rates allowed by, for example, Vimeo Provider), maybe we should change the name. I was thinking supportedRates but not fully convinced either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the PlaybackRates feature design — store state, configuration API, and
architectural decisions for consumer-configurable playback rate lists with
optional source plugin constraints.
Design summary
playback-ratesattribute on<media-player>/playbackRatesprop on<Player.Provider>— rates live at the rootsetRequestedRates,setSourceRates,setPlaybackRateplaybackRatesis a derived getter (intersection of requested and source),never stored directly
setSourceRates; no overlap → empty list,controls disabled