You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds an RFC proposing a player-scoped CSP nonce and a managed dynamic stylesheet system to remove the need for style-src 'unsafe-inline' while preserving dynamic styling in the HTML and React players.
Changes:
Documents current inline-style usage across HTML and React players and why it conflicts with strict CSP.
This doc reads beautifully, thanks for creating it! I agree with almost everything in it, however I'm going to close to avoid merging a stale doc (we already have so many we need to either update/remove) and to avoid having to iterate on it.
You're more than welcome to follow-up with a PR directly to solve this because I agree we need a solution for CSP. I quite like the Base UI CSPProvider direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.