Repository navigation
feat: support NativePHP custom SVG icons - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
custom:nameconvention.icon()API and platform override precedence.^4.1to^4.7.Why?
NativePHP Mobile 4.7 compiles application SVG icons into native iOS template assets and Android VectorDrawables. ToastKit previously transported
custom:namevalues but its native presentation layer could not display them consistently.How was it tested?
composer validate --strictcomposer test: 194 passed, 389 assertionsnode --test resources/js/tests/toastkit.test.js: 41 passedgit diff --checkPlatforms tested
Breaking changes?
No public API break. The minimum dependency is now NativePHP Mobile 4.7 because custom SVG assets rely on its native build pipeline. Applications on NativePHP Mobile 4.1 through 4.6 should remain on ToastKit 1.4.x until upgrading NativePHP.
Checklist