Repository navigation
ci: run public CI on GitHub-hosted runners - #108
Merged
Merged
Conversation
The operator ruled that public repositories run CI on GitHub-hosted runners, not Namespace. Both ci.yml jobs move from nscloud-ubuntu-24.04-amd64-4x8 to ubuntu-latest.
ReviewIncremental · 0 open
SummaryRunner label changes in
|
| Job | Before | After |
|---|---|---|
verify (Verify) |
nscloud-ubuntu-24.04-amd64-4x8 |
ubuntu-latest |
| Template | nscloud-ubuntu-24.04-amd64-4x8 |
ubuntu-latest |
What stays the same
- Fork guard: The Template job keeps its
if:condition. Pull requests from forks still skip this job because they get no secrets and cannot read the private template. - Pinned actions: Steps and action pins are untouched.
actions/checkoutstays pinned to the same commit SHA (v7.0.1). - Concurrency and triggers: These are not modified.
Review notes
- Floating OS version: The old label named the OS explicitly (Ubuntu 24.04, amd64).
ubuntu-latestis a floating alias, so the image's Ubuntu version can change when GitHub moves the alias. That change would happen without any edit to this repository. If CI needs a fixed OS, considerubuntu-24.04. Usingubuntu-latestmatches the other workflows listed in the description. - Machine size: The old label also set the machine size (
4x8). The new label uses GitHub's default hosted runner size, so job duration may differ for these two jobs.
Files
| File | Status | + | − |
|---|---|---|---|
.github/workflows/ci.yml |
modified | +2 | −2 |
Open
No open findings.
History
| When | Pass | Open |
|---|---|---|
| 15 Oct 16:59 UTC | Incremental | 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator ruled that public repositories run CI on GitHub-hosted runners, not Namespace. Both jobs in
ci.yml, Verify and Template, move fromnscloud-ubuntu-24.04-amd64-4x8toubuntu-latest. Nothing else changes.The other workflows already use GitHub-hosted runners:
version-pr.yml,publish.yml, andmounted-task.ymluseubuntu-latest,release-macos.ymlusesmacos-latest, and the release-asset matrix takes its labels from verctl. CI-only, so no changeset.