Skip to content

added trailing slash#49

Open
jasinner wants to merge 2 commits into
victims:masterfrom
jasinner:prevent-redirect
Open

added trailing slash#49
jasinner wants to merge 2 commits into
victims:masterfrom
jasinner:prevent-redirect

Conversation

@jasinner

@jasinner jasinner commented Sep 12, 2017

Copy link
Copy Markdown
Member

curl -v -L http://localhost:5000/service/remove/1970-01-01T00:00:00
redirects to:

curl -v -L http://localhost:5000/service/remove/1970-01-01T00:00:00/

This client library doesn't seem to follow redirects, so adding trailing slash directly.

@jasinner jasinner requested a review from abn September 12, 2017 03:51
@jasinner

Copy link
Copy Markdown
Member Author

Can you also push this update to Maven central @abn ?

@abn

abn commented Sep 14, 2017

Copy link
Copy Markdown
Member

@jasinner please clean up commits before I can merge this. Happy for the change to go in; but please raise an issue to allow redirects.

@abn abn self-assigned this Sep 14, 2017

@abn abn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits need to be cleaned up and no release commits expected in this PR.

@jasinner

Copy link
Copy Markdown
Member Author

Cleaned up commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants