feat: add ProtonVPN extension - #373 - #374
Conversation
feat(protonvpn): improve sign-in flow + UI
|
Thanks for contributing an extension to Vicinae! 👋 Before publication, this pull request receives two reviews:
✅ Ready for human review. The automated reviewer approved the latest commit and a maintainer has been notified. No blocking findings remain on the latest commit. The automated reviewer examines only the current commit. New commits invalidate its previous decision and start another review. |
clankus-aurelius
left a comment
There was a problem hiding this comment.
The extension introduces two misleading failure paths and an unrelated workspace dependency upgrade.
Automated review found 1 publication-blocking issue.
This is an AI-generated first pass and may be mistaken. If a finding is unclear or incorrect, reply in the relevant thread and mention @aurelleb.
clankus-aurelius
left a comment
There was a problem hiding this comment.
All previously reported issues are resolved, and the follow-up changes introduce no new actionable problems.
Automated extension review passed. A maintainer review is still required.
This is an AI-generated first pass and may be mistaken. If a finding is unclear or incorrect, reply in the relevant thread and mention @aurelleb.
|
@aurelleb automated review passed for |
|
Oh also of note is the fact that I tried to in-build the login flow to Vicinae's UI - because I know that telling the user to go run a command in their own terminal to sign-in is a bit long. However, from a bit of testing, I believe the Proton VPN CLI reads directly from |
ProtonVPN Extension
Adds a ProtonVPN extension that wraps the
protonvpnCLI.Commands
Features
protonvpnCLI is not found.Testing
Tested locally on NixOS with
protonvpnCLI installed.Notes