fix(deps): bump brace-expansion to 5.0.9 in apps/web (#50) - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
brace-expansionfrom 5.0.6 to 5.0.9 inapps/web, which fixes three high-severity DoS advisories. Dependabot's #39 only goes to 5.0.7, which fixes the first of them and leaves the other two open.Closes #50
Supersedes #39.
{}groupsGitHub auto-dismissed the Dependabot alerts for the last two advisories because
brace-expansionis development-only.npm auditstill reported them.Architecture summary
apps/web/package-lock.jsonchanges. The update came fromnpm update brace-expansion, andpackage.jsonis untouched.brace-expansionis a transitive dev dependency. The ESLint toolchain pulls it in throughminimatch10.2.5, which accepts^5.0.5. None of it ends up in the built app.Lockfile changes
Compared with
main, one package version changes, and nothing is added or removed:Security considerations
npm auditmeaningful for development dependencies too.Testing evidence
npm ci, lint,tsc --noEmit, vitest (17/17) andvite buildall pass.main's (index-C9FYIbTn.css,index-DB_pI0PC.js).npm auditno longer listsbrace-expansion.git diff --checkis clean.Known limitations
@vitest/mockerin chore(deps): bump @vitest/mocker and vitest in /apps/web #45, postcss-selector-parser in chore(deps): bump postcss-selector-parser from 6.1.2 to 6.1.4 in /apps/web #43.Follow-up issues
Checklist
main; this PR targetsmain.make verifypasses locally.git diff --checkis clean.