Fix mlmodel pip install command to quote extras syntax#1176
Open
Fix mlmodel pip install command to quote extras syntax#1176
Conversation
shells like zsh interpret brackets as glob patterns, so the command needs quotes: pip install 'viam-sdk[mlmodel]' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/viam/services/mlmodel/__init__.pysuggestedpip install viam-sdk[mlmodel], which fails on shells like zsh because[and]are interpreted as glob pattern characterspip install 'viam-sdk[mlmodel]'with proper quotingTest plan
🤖 Generated with Claude Code